[PATCH] D127188: [InstCombine] improve fold for icmp-ugt-ashr

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - it may be worth looking at the related folds to see if there's some generalization that we missed (see inline comment about the other TODO comment in the test file).



================
Comment at: llvm/test/Transforms/InstCombine/icmp-shr.ll:858
 ; negative test
 ; TODO: This is a sign-bit test, but we don't recognize the pattern.
 
----------------
Check the history to see where this got fixed? Either way, we should delete the TODO since it optimized now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127188/new/

https://reviews.llvm.org/D127188