[PATCH] D126434: [PseudoProbe] Use callee name as callsite identfier for MCDecodedPseudoProbeInlineTree.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:576
     return nullptr;
-  return getFuncDescForGUID(std::get<0>(InlinerNode->ISite));
+  return getFuncDescForGUID(InlinerNode->Parent->Guid);
 }
----------------
wenlei wrote:
> hoy wrote:
> > wenlei wrote:
> > > is `std::get<0>(xx->ISite)` equivalent to `xx->Parent->Guid`? 
> > They were equivalent, but they are not with this patch. Note that we are changing `std::get<0>(xx->ISite)` to the inlinee's Guid at line 419 above. 
> Got it. Can you update the comment below to make it explicit that the GUID is callee's. 
> 
> > // An inline frame has the form <Guid, ProbeID>
> > using InlineSite = std::tuple<uint64_t, uint32_t>;
Good point, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126434/new/

https://reviews.llvm.org/D126434