[PATCH] D127318: [cmake] Add missing dependencies to objlib in add_llvm_executable.

Wed Jun 8 09:29:34 PDT 2022

beanz accepted this revision.
beanz added a comment.

LGTM, one comment.

================
Comment at: llvm/cmake/modules/AddLLVM.cmake:966
+    # Add dependencies also to obj_name
+    # CMake issue 14747 --  add_dependencies() might be ignored to obj_name's user.
+    foreach(objlib ${obj_name})
----------------
Unless I'm misunderstanding the behavior issues you're seeing here are a bug in our code not CMake.  IIUC, the issue you're seeing is that since the objlib doesn't depend on the tablegen targets, it is likely failing to build or building out of order. That's clearly a bug in our code, not CMake.

I know that you copied that comment, but it doesn't seem relevant here, and I think it is describing a situation that isn't actually a bug in CMake.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127318/new/

https://reviews.llvm.org/D127318