[PATCH] D125255: [llvm-profgen] Support a threshold to control hiding warning summaries
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 8 08:13:26 PDT 2022
wenlei added a comment.
I think we also need to decide what should always be emitted. Now there's only one warning that is always emitted. I think we can benefit from another always emit warning that can tells us when profile/binary mismatch and/or the issues like the skylake PMU bug happens. Do we get any indicator now for these issues?
When simplifying, we still want to let user know very meaningful signal, but we don't want to present 10 signals to users, instead we want to give them a couple important signals, I think signal for profile/binary mismatch etc can be considered important?
It looks like we already have a verbose mode `show-detailed-warning`, maybe we can reuse that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125255/new/
https://reviews.llvm.org/D125255
More information about the llvm-commits
mailing list