[PATCH] D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.

LGTM, with a request for a doc comment



================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectWatchBase.py:145
 
+    def _evaluate_as_floating_point(self, expected_value):
+        try:
----------------
IMHO: this wants a docustring explaining what it's doing, which as I understand it, is replacing expected_value with a nearby float value, if it's within the float_range, to ensure that it passes an equality comparision. (Writing this down will ease the future readers task).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124511/new/

https://reviews.llvm.org/D124511