[PATCH] D126898: [COFF] Check table ptr more thoroughly and ignore empty sections

Alvin Wong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 06:19:21 PDT 2022


alvinhochun added a comment.

Yeah, that seems fine as a workaround. https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#section-table-section-headers says:

> If this (VirtualSize) value is greater than SizeOfRawData, the section is zero-padded.

This means the RVA should technically be pointing to a block of zeros. If we pretend the section does not exist at all, it is probably still good enough, right?

But I wonder if the code should always just use the `.reloc` section and ignore the Base Relocation Table RVA if it points to somewhere odd?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126898/new/

https://reviews.llvm.org/D126898



More information about the llvm-commits mailing list