[PATCH] D126661: [MachineVerifier] Fix crash on early clobbered subreg operands.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 05:58:41 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir:1
+# RUN: llc -mtriple amdgcn-amd-amdhsa -run-pass=liveintervals,simple-register-coalescing -verify-machineinstrs -o - %s | FileCheck %s
+# REQUIRES: amdgpu-registered-target
----------------
tests in test/MachineVerifier should run none to just run the verifier. Shouldn't be running codegen passes


================
Comment at: llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir:9-12
+registers:
+  - { id: 0, class: vgpr_32, preferred-register: '' }
+  - { id: 1, class: vgpr_32, preferred-register: '' }
+  - { id: 2, class: vreg_64, preferred-register: '' }
----------------
Don't need the register section


================
Comment at: llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir:19
+    INLINEASM &"", 0 /* attdialect */,  1835019 /* regdef-ec:VGPR_32 */, def undef early-clobber %2.sub0, 1835018 /* regdef:VGPR_32 */, def undef %2.sub1
+    FLAT_STORE_DWORDX2 $vgpr0_vgpr1, %2, 0, 0, implicit $exec, implicit $flat_scr :: (store (s64))
+    S_ENDPGM 0
----------------
Set the register class like %2:vreg_64?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126661/new/

https://reviews.llvm.org/D126661



More information about the llvm-commits mailing list