[PATCH] D127279: [SelectionDAG] Handle bzero/memset libcalls globally instead of per target

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 05:39:16 PDT 2022


gchatelet added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/arm64_32.ll:735
 
 define void @test_bzero(i64 %in)  {
 ; CHECK-LABEL: test_bzero:
----------------
courbet wrote:
> courbet wrote:
> > can you add a `test_memset` with a nonzero value for the pattern ?
> Wait actually this was tested in `arm64-memset-to-bzero.ll` which this patch deletes. Why is that ?
You're right it should not be deleted, only trimmed from the 256 constraint tests. I'll revert it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127279/new/

https://reviews.llvm.org/D127279



More information about the llvm-commits mailing list