[PATCH] D125680: Correctly legalise stackmap operands

[Edd Barrett via Phabricator via llvm-commits]

vext01 updated this revision to Diff 435111.
vext01 added a comment.
Herald added a subscriber: jsji.

Here is the latest version of this diff.

Also in the meantime I've extended the stackmap tests to give us a reasonable degree of confidence that this change is not breaking things.

- Added some `i128` tests in D126069 <https://reviews.llvm.org/D126069> (merged)
- Added some `float` tests in D126204 <https://reviews.llvm.org/D126204> (merged)
- Added runtime stackmap tests in D126552 <https://reviews.llvm.org/D126552> (needs review)

I had planned to include legalisation tests for things like vectors, structs and integers greater than 64-bits, but since those types already don't work properly with stackmaps (i.e. when already legal), I think that should be a separate change.

For more info on those issues, see:

- https://github.com/llvm/llvm-project/issues/26431#issuecomment-1132697106
- https://github.com/llvm/llvm-project/issues/55609
- https://github.com/llvm/llvm-project/issues/55649
- https://github.com/llvm/llvm-project/issues/55613

I hope this diff is nearing completion, but D126552 <https://reviews.llvm.org/D126552> should go in first (I'm struggling to find reviewers for that one, any takers?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680

Files:
  llvm/include/llvm/CodeGen/ISDOpcodes.h
  llvm/include/llvm/CodeGen/SelectionDAGISel.h
  llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  llvm/test/CodeGen/X86/selectiondag-stackmap-legalize.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125680.435111.patch
Type: text/x-patch
Size: 15968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220608/b7a0d419/attachment.bin>