[PATCH] D126898: [COFF] Check table ptr more thoroughly and ignore empty sections

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 02:35:33 PDT 2022


mstorsjo added a comment.

In D126898#3565834 <https://reviews.llvm.org/D126898#3565834>, @glandium wrote:

> I don't have time to provide more details right now, but this change broke Firefox mingw builds with: `llvm-strip: error: '../../dist/firefox/uninstall/helper.exe': RVA 0x43000 for base reloc table found but data is incomplete`
>
> That `helper.exe` file is produced by NSIS.

Can you upload that binary somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126898/new/

https://reviews.llvm.org/D126898



More information about the llvm-commits mailing list