[PATCH] D127095: [llvm][CodeGen] Add a default implementation to check whether two memory accesses are trivially disjoint
Xiaoqiang Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 7 21:18:12 PDT 2022
csstormq added a comment.
In D127095#3564745 <https://reviews.llvm.org/D127095#3564745>, @efriedma wrote:
> You might want to look at TargetSubtargetInfo::useAA() and TargetSubtargetInfo::enableMachineScheduler(); might be helpful for your target, depending on what you're doing. (Actually, maybe we should consider just turning these on by default for all targets, given the number of targets overriding them.)
I have tried TargetSubtargetInfo::useAA for my target, but it is not helpful for my case.
I will try TargetSubtargetInfo::enableMachineScheduler() later. Thank you for your advice!
In D127095#3564745 <https://reviews.llvm.org/D127095#3564745>, @efriedma wrote:
> If you want to refactor out the relevant bits of MachineInstr::mayAlias into a helper, then enhance it, that would be fine, I guess. It's just weird to have two separate codepaths for checking MachineMemOperands.
I agree with your idea. I have submitted a new patch. Please review it again. At last, whether the title and summary need re edit to accord with the latest patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127095/new/
https://reviews.llvm.org/D127095
More information about the llvm-commits
mailing list