[PATCH] D95210: Update the ProgrammersManual explanation for ilist and iplist
Nathan Lanza via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 7 19:51:50 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9b3c5cba9f71: Update the ProgrammersManual explanation for ilist and iplist (authored by lanza).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95210/new/
https://reviews.llvm.org/D95210
Files:
llvm/docs/ProgrammersManual.rst
Index: llvm/docs/ProgrammersManual.rst
===================================================================
--- llvm/docs/ProgrammersManual.rst
+++ llvm/docs/ProgrammersManual.rst
@@ -1705,6 +1705,9 @@
list, and ``ilist``\ s are guaranteed to support a constant-time splice
operation.
+An ``ilist`` and an ``iplist`` are ``using`` aliases to one another and the
+latter only currently exists for historical purposes.
+
These properties are exactly what we want for things like ``Instruction``\ s and
basic blocks, which is why these are implemented with ``ilist``\ s.
@@ -1712,8 +1715,6 @@
* :ref:`ilist_traits <dss_ilist_traits>`
-* :ref:`iplist <dss_iplist>`
-
* :ref:`llvm/ADT/ilist_node.h <dss_ilist_node>`
* :ref:`Sentinels <dss_ilist_sentinel>`
@@ -1754,19 +1755,8 @@
ilist_traits
^^^^^^^^^^^^
-``ilist_traits<T>`` is ``ilist<T>``'s customization mechanism. ``iplist<T>``
-(and consequently ``ilist<T>``) publicly derive from this traits class.
-
-.. _dss_iplist:
-
-iplist
-^^^^^^
-
-``iplist<T>`` is ``ilist<T>``'s base and as such supports a slightly narrower
-interface. Notably, inserters from ``T&`` are absent.
-
-``ilist_traits<T>`` is a public base of this class and can be used for a wide
-variety of customizations.
+``ilist_traits<T>`` is ``ilist<T>``'s customization mechanism. ``ilist<T>``
+publicly derives from this traits class.
.. _dss_ilist_node:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95210.435031.patch
Type: text/x-patch
Size: 1398 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220608/86c41034/attachment.bin>
More information about the llvm-commits
mailing list