[PATCH] D127136: [RegisterCoalescer] Fix crash on early clobbered subreg operands.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:2746
     // Keep this value, check for conflicts when analyzing OtherVNI.
-    if (!OtherV.isAnalyzed())
+    if (!OtherV.isAnalyzed() || Other.Assignments[OtherVNI->id] == -1)
       return CR_Keep;
----------------
Could use a comment


================
Comment at: llvm/test/CodeGen/AMDGPU/coalescer-early-clobber-subreg.mir:7
+# The issue was with processing two subregs of the same reg are used in the
+# same instruction (e.g. inline asm): "def early-clobber" and other just "def".
+# Register coalescer ran in bad recursion if the early clobbered subreg is
----------------
Missing word between "and other"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127136/new/

https://reviews.llvm.org/D127136