[PATCH] D127057: [JITLink][ELF/AARCH64] Implement R_AARCH64_ADR_GOT_PAGE and R_AARCH64_LD64_GOT_LO12_NC

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 18:09:39 PDT 2022


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

LGTM.

> I brought a lot of code from Macho/ARM64 backend's GOT manager and it looks very possible to unify them to generic aarch64 got table manager.

Absolutely -- it would be great to unify these.

> I thought it's better to unify them in the later patch to focus changes on ELF backend, but I can do it in this patch if that's preferred.

I think it makes sense to land this as-is, then unify support in a follow-up patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127057/new/

https://reviews.llvm.org/D127057



More information about the llvm-commits mailing list