[PATCH] D126930: Fix interaction of CFI instructions with MachineOutliner.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2216
 
+  case MachineOperand::MO_CFIIndex:
+    if (MO->getCFIIndex() >= MF->getFrameInstructions().size())
----------------
smeenai wrote:
> smeenai wrote:
> > Unfortunately, this doesn't appear to be enough to catch this issue. If I undo the other changes in this diff and remove the assertion I added in D126919, the test case from https://github.com/llvm/llvm-project/issues/55842 still crashes with an unexpected instruction error instead of hitting this check.
> NVM, this was PEBKAC – I forgot to pass `-verify-machineinstrs` to llc. I imagine Clang does that automatically.
verify-machineinstrs is expensive because it checks after every pass.  So it's off by default in all tools.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126930/new/

https://reviews.llvm.org/D126930