[PATCH] D126930: Fix interaction of CFI instructions with MachineOutliner.

Tue Jun 7 16:26:40 PDT 2022

smeenai accepted this revision.
smeenai added a comment.

LGTM, thank you!

================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2216

+  case MachineOperand::MO_CFIIndex:
+    if (MO->getCFIIndex() >= MF->getFrameInstructions().size())
----------------
Unfortunately, this doesn't appear to be enough to catch this issue. If I undo the other changes in this diff and remove the assertion I added in D126919, the test case from https://github.com/llvm/llvm-project/issues/55842 still crashes with an unexpected instruction error instead of hitting this check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126930/new/

https://reviews.llvm.org/D126930