[PATCH] D127223: [BOLT] Set valid index for functions with profiles

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added a comment.

> Some of the passes that calculates tentative layout like LongJmp and Golang are expecting that only functions with valid index will be located in hot text section.

Do these passes care about functions written to cold text at all? I wonder if we need to assign indices to all functions regardless of the profile.



================
Comment at: bolt/lib/Passes/ReorderFunctions.cpp:132
+  // Assign valid index for functions with valid profile.
+  for (auto &it : BFs) {
+    BinaryFunction &BF = it.second;
----------------
Or `KV`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127223/new/

https://reviews.llvm.org/D127223