[PATCH] D126254: Add support for decoding base64.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/Support/Base64.h:56
 
+template <class OutputBytes>
+llvm::Error decodeBase64(llvm::StringRef Input, OutputBytes &Output) {
----------------
Why the template? Would something like `SmallVectorImpl<uint8_t>` work here?


================
Comment at: llvm/include/llvm/Support/Base64.h:57
+template <class OutputBytes>
+llvm::Error decodeBase64(llvm::StringRef Input, OutputBytes &Output) {
+  // Invalid table value with short name to fit in the table init below. The
----------------
I think an `ErrorOr<OutputBytes>` or `Optional<OutputBytes>` would be more idiomatic here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126254/new/

https://reviews.llvm.org/D126254