[PATCH] D127148: [ELF] Support 'G' in lld

[Florian Mayer via Phabricator via llvm-commits]

fmayer updated this revision to Diff 434927.
fmayer added a comment.

address comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127148/new/

https://reviews.llvm.org/D127148

Files:
  lld/ELF/EhFrame.cpp
  lld/test/ELF/stack-tagging-cfi.s
  llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s


Index: llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
===================================================================
--- llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
+++ llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
@@ -1,5 +1,5 @@
-# RUN: llvm-mc -filetype=obj -triple aarch64-generic-linux -mattr=+mte %s -o %t.o
-# RUN: llvm-objdump -s --dwarf=frames %t.o | FileCheck %s
+# RUN: llvm-mc -filetype=obj -triple aarch64 -mattr=+mte %s -o %t.o
+# RUN: llvm-objdump --dwarf=frames %t.o | FileCheck %s
 
 # CHECK: Augmentation:          "zRG"
 
@@ -16,6 +16,3 @@
 	.size	WithUnwind, .Lfunc_end0-WithUnwind
 	.cfi_endproc
                                         // -- End function
-	.globl	NoUnwind                        // -- Begin function NoUnwind
-	.p2align	2
-	.type	NoUnwind, at function
Index: lld/test/ELF/stack-tagging-cfi.s
===================================================================
--- lld/test/ELF/stack-tagging-cfi.s
+++ lld/test/ELF/stack-tagging-cfi.s
@@ -1,5 +1,6 @@
 # RUN: llvm-mc -filetype=obj -triple aarch64-generic-linux -mattr=+mte %s -o %t.o
-# RUN: llvm-objdump -s --dwarf=frames %t.o | FileCheck %s
+# RUN: ld.lld --eh-frame-hdr %t.o -o %t
+# RUN: llvm-objdump -s --dwarf=frames %t | FileCheck %s
 
 # CHECK: Augmentation:          "zRG"
 
Index: lld/ELF/EhFrame.cpp
===================================================================
--- lld/ELF/EhFrame.cpp
+++ lld/ELF/EhFrame.cpp
@@ -171,7 +171,7 @@
       readByte();
     else if (c == 'P')
       skipAugP();
-    else if (c != 'B' && c != 'S')
+    else if (c != 'B' && c != 'S' && c != 'G')
       failOn(aug.data(), "unknown .eh_frame augmentation string: " + aug);
   }
   return DW_EH_PE_absptr;
@@ -188,7 +188,7 @@
       skipAugP();
     else if (c == 'R')
       readByte();
-    else if (c != 'B' && c != 'S')
+    else if (c != 'B' && c != 'S' && c != 'G')
       failOn(aug.data(), "unknown .eh_frame augmentation string: " + aug);
   }
   return false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127148.434927.patch
Type: text/x-patch
Size: 1962 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220607/64247604/attachment.bin>