[PATCH] D126999: [BOLT][DWARF] Change loclist to take not delay writing out lists.

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added a comment.

"[BOLT][DWARF] Change loclist to take not delay writing out lists." -> "[BOLT]DWARF] Eagerly write out loclists".

Could you add more background in the Summary and include memory footprint reduction data?



================
Comment at: bolt/include/bolt/Core/DebugData.h:39
+  DWARFFormValue V;
+  const DWARFAbbreviationDeclaration *AbbrevDecl;
+  uint64_t Offset;
----------------
Drop `const` here.


================
Comment at: bolt/include/bolt/Core/DebugData.h:527
 private:
+  /// Inits all the relative data structures.
+  void init();
----------------
s/relative/related/


================
Comment at: bolt/include/bolt/Core/DebugData.h:601
+  std::vector<uint32_t> RelativeLocListOffsets;
+  uint32_t NumberOfentries{0};
+  static uint32_t LoclistBaseOffset;
----------------
Or `NumEntries`.


================
Comment at: bolt/lib/Core/DebugData.cpp:81-85
+/// Finds attributes FormValue and Offset.
+///
+/// \param DIE die to look up in.
+/// \param Attr the attribute to extract.
+/// \return an optional AttrInfo with DWARFFormValue and Offset.
----------------
No need to duplicate comments from the header.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:177
     opts::DeterministicDebugInfo = true;
+    llvm::errs()
+        << "BOLT-WARNING: --deterministic-debuginfo is being deprecated.\n";
----------------



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:178
+    llvm::errs()
+        << "BOLT-WARNING: --deterministic-debuginfo is being deprecated.\n";
+  }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126999/new/

https://reviews.llvm.org/D126999