[PATCH] D127070: [ADT][NFC] Early bail out for ComputeEditDistance

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Looks good, thanks!



================
Comment at: llvm/unittests/ADT/EditDistanceTest.cpp:35-36
+TEST(EditDistance, VerifyShortCircuit) {
+  StringRef Hello("Hello");
+  StringRef HelloWorld("HelloWorld");
+  Result R = editDistanceAndMaps(Hello, HelloWorld, 5);
----------------
Generally prefer implicit construction over explicit where they're both valid - since implicit is strictly less powerful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127070/new/

https://reviews.llvm.org/D127070