[PATCH] D127199: [LoongArch 1/n] Add codegen support for the binary operations

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 10:56:50 PDT 2022


rengolin added a comment.

In D127199#3564217 <https://reviews.llvm.org/D127199#3564217>, @xry111 wrote:

> Does anyone have any idea about "why the CI is failing"?  It seems happening for this batch of LoongArch patches and also one MIPS patch I've reviewed today.  I guess something is wrong in the CI system or LLVM codebase.

This pre-commit CI isn't trust-worthy. The LLVM codebase relies on live buildbots that test `main` and warrant reverts if they break, instead of duplicating all tests as pre-commit (too many!) and then get something wrong after merge.

What I do, and I recommend to everyone merging patches to `main` is to run a build + `check-all` with the tools you need (llvm only, clang, etc).

If `main` is failing without your patch and your patch doesn't add any more failures (nor change the existing failures) it should be ok to merge.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127199/new/

https://reviews.llvm.org/D127199



More information about the llvm-commits mailing list