[PATCH] D127140: [APFloat] Fix truncation of certain subnormal numbers

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

New patch looks better.

Can you add unittests for the float->bfloat case I mentioned before?



================
Comment at: llvm/lib/Support/APFloat.cpp:2217
+  // Also do a similar trick in case shifting denormal would produce zero
+  // significand as this caseisn't handled correctly by normalize.
   if (shift < 0 && isFiniteNonZero()) {
----------------
"caseisn't" -> "case isn't"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127140/new/

https://reviews.llvm.org/D127140