[PATCH] D127147: [DirectX] Add MC Register and Frame stubs

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

LGTM but please get a second approval before submitting.



================
Comment at: llvm/lib/Target/DirectX/DirectXFrameLowering.h:29-34
+  void emitPrologue(MachineFunction &MF,
+                    MachineBasicBlock &MBB) const override {}
+  void emitEpilogue(MachineFunction &MF,
+                    MachineBasicBlock &MBB) const override {}
+
+  bool hasFP(const MachineFunction &MF) const override { return false; }
----------------
beanz wrote:
> kuhar wrote:
> > I'm afraid these can lead to unused function argument warnings. Can we remove argument names to silence such warnings?
> I'm happy to make this change (I prefer it myself), but I do want to point out that LLVM is nowhere near clean for `-Wunused-parameter`, and it isn't a warning we generally support.
Ack, so it must have been llvm headers being pulled into other projects that generated such warnings for me in the past. Feels free to disregard this in other reviews that I sent as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127147/new/

https://reviews.llvm.org/D127147