[PATCH] D127131: Pipe potentially invalid InstructionCost through CodeMetrics

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D127131#3562661 <https://reviews.llvm.org/D127131#3562661>, @frasercrmck wrote:

> Thanks for the patch, @reames. I agree that invalid costs should never crash. Not just because it allows targets with incomplete models to work but there might always be something that's truly invalid for a target even with a complete model.
>
> For testing, would we possibly be able to test scalable vectors on RISC-V without `V` enabled?

Good idea.  I'll add some basic test coverage for the cost model printer itself with that approach.  I don't plan on adding individual tests for each transform pass - mostly because figuring out to trigger each with a small test case seems quite tedious and not particularly worthwhile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127131/new/

https://reviews.llvm.org/D127131