[PATCH] D127179: [RISCV] Scalarize gather/scatter on RV64 with Zve32* extension.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 07:52:11 PDT 2022


reames added a comment.

In D127179#3563583 <https://reviews.llvm.org/D127179#3563583>, @craig.topper wrote:

> In D127179#3563571 <https://reviews.llvm.org/D127179#3563571>, @reames wrote:
>
>> LGTM.  I'm fine with this landing, regardless of the answer to the following.
>>
>> Having said that, given we really don't support zvl32b, should we bother?  I'm tempted to simply document the lack of support instead, and defer this until someone cares.  Having it half supported, half not seems worse than explicitly not supported.
>
> This patch allows Zve32f or Zve32x with Zvl64b or higher. Meaning elements limited to 32 bits and total vector size >= 64.

Ah, so I misunderstand the context.

Still LGTM.

The number of combinations we have here is absolutely ridiculous.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127179/new/

https://reviews.llvm.org/D127179



More information about the llvm-commits mailing list