[PATCH] D127208: MachineSink debug invariance

[Markus Lavin via Phabricator via llvm-commits]

markus added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:274
+  for (auto &MI : MBB) {
+    if (MI.isDebugInstr())
+      continue;
----------------
Orlando wrote:
> Should this be `.isMetaInstr()` (rather than `.isDebugInstr()`) to cover other non-debug that do not correspond to executable instructions?
Not sure but the way we do it now should be equivalent to how it works in `BasicBlock::sizeWithoutDebug()` which I guess is the way it should be.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127208/new/

https://reviews.llvm.org/D127208