[PATCH] D127135: [Object][Archive] Support a new archive member /<ECSYMBOLS>/

Tue Jun 7 05:46:04 PDT 2022

jhenderson added a comment.

In D127135#3561301 <https://reviews.llvm.org/D127135#3561301>, @pzheng wrote:

> In D127135#3561269 <https://reviews.llvm.org/D127135#3561269>, @thieta wrote:
>
>> I think you can drop the content lines from the test cases. But other that that it looks fine.
>
> I tried removing the content lines from the test case, but got the following error somehow. Any idea?
>
> "truncated or malformed archive (offset to next archive member past the end of the archive after member foo-arm64ec.obj)"

Did you update the `Size` fields too? I suspect those might be the problem. I also think you should inline the test input into the test file, since it's presumably only going to be used in the one test - having the test input close to the test commands themselves makes it easier to see what the test is doing. Finally, if you don't need all the library members for the test (it doesn't look to me like you do), you should remove them, leavnig only the ECSYMBOLS one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127135/new/

https://reviews.llvm.org/D127135