[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 05:42:51 PDT 2022


foad added a comment.

> Deep patterns ends up with a combinatorial explosion of cases to match for their argument because there is no guarantee that they have already been combined.

Absolutely! I am astonished that DAGCombine does not provide this guarantee, and I am strongly in favour of trying to fix it if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list