[PATCH] D126889: [NFC] format InstructionSimplify & lowerCaseFunctionNames

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 03:22:42 PDT 2022


simoll added a comment.

In D126889#3559904 <https://reviews.llvm.org/D126889#3559904>, @foad wrote:

> No objection from me, and I do maintain downstream forks. Can you provide a simple one-line command that I can run to make the equivalent changes in my downstream?

Apart from applying the patch, not really. This is clang-format + lower-case all function names in InstCombine.cpp/h + compile, wait for an error and lower-case the highlighted function name in the error message, repeat.

In D126889#3559978 <https://reviews.llvm.org/D126889#3559978>, @spatel wrote:

> In D126889#3559904 <https://reviews.llvm.org/D126889#3559904>, @foad wrote:
>
>> No objection from me, and I do maintain downstream forks. Can you provide a simple one-line command that I can run to make the equivalent changes in my downstream?
>
> I'm guessing this used a basic grep for "Simplify", but that needs refinement if we proceed - see inline comments for some mistakes.

Yes. I've started with string replacement in InstSimplify. The latest Diff is with manual refinements, that is going through the Diff line by line and mending unintentional changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126889/new/

https://reviews.llvm.org/D126889



More information about the llvm-commits mailing list