[PATCH] D127101: [Dexter] Catch value error when encountering invalid address
Orlando Cazalet-Hyams via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 7 02:53:04 PDT 2022
Orlando added a comment.
I've added an inline suggestion but I'm happy with or without that change, LGTM.
================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexDeclareAddress.py:54
except KeyError:
pass
else:
----------------
Changing the `pass` here to `continue`, then dropping the `else:` may improve readability now that the additional `try` block is required.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127101/new/
https://reviews.llvm.org/D127101
More information about the llvm-commits
mailing list