[PATCH] D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects

Mon Jun 6 23:31:45 PDT 2022

tingwang added a comment.

In D86669#3560983 <https://reviews.llvm.org/D86669#3560983>, @efriedma wrote:

> If you're seeing a miscompile, something is probably wrong with the caller.  getUnderlyingObjects() is, in general, not guaranteed to produce an identifiable object.  If the caller cares, it should check; for example, GlobalsAAResult::getModRefInfoForArgument checks `all_of(Objects, isIdentifiedObject)`.

Thank you for pointing out the direction. It seems the caller AddAliasScopeMetadata() is making the false assumption without additional check. I will dig a little bit into history, and maybe submit a patch to fix that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86669/new/

https://reviews.llvm.org/D86669