[PATCH] D126286: [JITLink] [ELF/AARCH64] Generic aarch64 patch fixups
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 21:31:16 PDT 2022
lhames added inline comments.
================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h:194-197
+ default:
+ return make_error<JITLinkError>(
+ "In graph " + G.getName() + ", section " + B.getSection().getName() +
+ "unsupported edge kind" + getEdgeKindName(E.getKind()));
----------------
lhames wrote:
> This triggered a covered switch warning for me:
>
> ```
> [660/896] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_aarch64.cpp.o
> llvm-github/llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp:110:5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
> default:
> ^
> llvm-github/llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp:110:5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
> llvm-github/llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp:67:54: note: in instantiation of member function 'llvm::jitlink::ELFLinkGraphBuilder_aarch64<llvm::object::ELFType<llvm::support::little, true>>::addSingleRelocation' requested here
> &Self::addSingleRelocation))
> ^
> llvm-github/llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp:148:10: note: in instantiation of member function 'llvm::jitlink::ELFLinkGraphBuilder_aarch64<llvm::object::ELFType<llvm::support::little, true>>::addRelocations' requested here
> return ELFLinkGraphBuilder_aarch64<object::ELF64LE>((*ELFObj)->getFileName(),
> ```
>
> I think it can just be commented out for now, and re-enabled when the GOT edges are moved out of `applyFixup`.
> This triggered a covered switch warning for me: ...
Ignore this -- it's a stale review comments that I failed to remove.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126286/new/
https://reviews.llvm.org/D126286
More information about the llvm-commits
mailing list