[PATCH] D127166: [DirectX] Add DirectX target object writer

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DirectXSubtarget.h:47
+
+  const DirectXFrameLowering *getFrameLowering() const override { return &FL; }
+
----------------
https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers ?


================
Comment at: llvm/lib/Target/DirectX/MCTargetDesc/DirectXMCTargetDesc.cpp:138-139
+static MCRegisterInfo *createDirectXMCRegisterInfo(const Triple &Triple) {
+  MCRegisterInfo *X = new MCRegisterInfo();
+  return X;
+}
----------------
nit: return directly? Also below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127166/new/

https://reviews.llvm.org/D127166