[PATCH] D127148: [ELF] Support 'G' in lld

[Florian Mayer via Phabricator via llvm-commits]

fmayer added a comment.

In D127148#3562065 <https://reviews.llvm.org/D127148#3562065>, @MaskRay wrote:

> llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code can be tested with llvm-objdump/llvm-dwarfdump but should have a test in `test/DebugInfo`.
>
> lld doesn't use llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code. It's inappropriate to rely on lld/test/ELF to provide the test coverage.
>
> You should move llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp into another patch with a test/DebugInfo patch.

Done, moved DWARF change to D127171 <https://reviews.llvm.org/D127171>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127148/new/

https://reviews.llvm.org/D127148