[PATCH] D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions

Mon Jun 6 17:42:23 PDT 2022

fmayer added a comment.

In D127007#3562022 <https://reviews.llvm.org/D127007#3562022>, @fmayer wrote:

> In D127007#3562017 <https://reviews.llvm.org/D127007#3562017>, @eugenis wrote:
>
>> In D127007#3562002 <https://reviews.llvm.org/D127007#3562002>, @fmayer wrote:
>>
>>> In D127007#3561986 <https://reviews.llvm.org/D127007#3561986>, @eugenis wrote:
>>>
>>>> Should we have a test for the augmentation string, through llvm-readelf?
>>>
>>> We have that test the follow-up CL that does the change to lld (as requested to be split by MaskRay).
>>
>> Hmm ok. This tests does not really need to involve lld at all, but that's fine.
>
> It does, because we need LLD so we can get an ELF file (which we then can `readelf` or, as the test does `objdump`).

Good point. The change to the DWARF parser for that is also in the follow up change though, but I changed the test to both check the `.o` and the `.so` files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127007/new/

https://reviews.llvm.org/D127007