[PATCH] D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 17:18:52 PDT 2022


eugenis added a comment.

Should we have a test for the augmentation string, through llvm-readelf?



================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:1289
+  case AArch64::EMITMTETAGGED: {
+    ExceptionHandling ExceptionHandlingType = MAI->getExceptionHandlingType();
+    if (ExceptionHandlingType != ExceptionHandling::DwarfCFI &&
----------------
As we've seen recently, sometimes even nounwind frames get unwound. Is it possible to relax some of these conditions to emit the "G" in as many cases as possible? This is the situation where MTE is more demanding to the unwind correctness, so I'd rather err on the safe side.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127007/new/

https://reviews.llvm.org/D127007



More information about the llvm-commits mailing list