[PATCH] D127037: [OpenMP][IRBuilder] 'omp target enter data' support.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D127037#3558523 <https://reviews.llvm.org/D127037#3558523>, @abidmalikwaterloo wrote:

> Do we need test cases for this patch?

yes. At least a unittest that calls `createTargetEnterData`.



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3681-3685
+  llvm::Value *PointerNum = nullptr;
+  llvm::Value *BasePointersArrayArg = nullptr;
+  llvm::Value *PointersArrayArg = nullptr;
+  llvm::Value *SizesArrayArg = nullptr;
+  llvm::Value *MapTypesArrayArg = nullptr;
----------------
OpenMPIRBuilder is part of the `llvm` namespace, therefore `llvm::` qualifiers are unnecessary.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3691-3692
+    // with noALiasDep details.
+    llvm::Value *noAliasDepNum = nullptr;
+    llvm::Value *noAliasDepList = nullptr;
+    if (NumDependences == nullptr) {
----------------
[style] In the LLVM project, please use the [[ https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly | LLVM coding style ]].


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127037/new/

https://reviews.llvm.org/D127037