[PATCH] D126626: [OpenMP][IRBuilder] Add final clause to task

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM with a request to describe the `llvm::Value` argument more precisely.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:627
   /// \param Tied True if the task is tied, false if the task is untied.
+  /// \param IsFinal True if the task is final, false if the task is not final.
   InsertPointTy createTask(const LocationDescription &Loc,
----------------
Since `IsFinal` is not a `bool`, you cannot pass true/false like for `Tied`. What is passed is the llvm::Value that decides whether to create a (non-)final task at runtime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126626/new/

https://reviews.llvm.org/D126626