[PATCH] D127140: [APFloat] Fix truncation of certain subnormal numbers

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I'm not sure it's safe to assume that the lost fraction is lfLessThanHalf, in general.  At least, it isn't obvious to me, particularly for cases involving bfloat.

We already have a bunch of code to adjust the shift amount for truncations: the "If this is a truncation of a denormal number [...]" block.  Can we adjust that code to reduce the shift amount in this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127140/new/

https://reviews.llvm.org/D127140