[PATCH] D126930: Fix interaction of CFI instructions with MachineOutliner.

[Kyungwoo Lee via Phabricator via llvm-commits]

kyulee added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-cfi-tail.mir:37
+  bb.1:
+    frame-setup CFI_INSTRUCTION def_cfa $w29, 16
 ...
----------------
I understand this will make a difference to outline it if we can prove this is dead and thus safely ignore it -- probably at the cost of walking IRs or blocks for all parent functions of candidates.
Do you see this case often in practice or is it just synthesized for this testing purpose?
Even if that is the case, I think this is irrelevant for this fix, and probably suggest another patch as an optimization (or improving it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126930/new/

https://reviews.llvm.org/D126930