[PATCH] D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 11:16:30 PDT 2022


efriedma added a comment.

If you're seeing a miscompile, something is probably wrong with the caller.  getUnderlyingObjects() is, in general, not guaranteed to produce an identifiable object.  If the caller cares, it should check; for example, GlobalsAAResult::getModRefInfoForArgument checks `all_of(Objects, isIdentifiedObject)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86669/new/

https://reviews.llvm.org/D86669



More information about the llvm-commits mailing list