[PATCH] D126754: [MachineSink] Clear kill flags on operands outside loop

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 09:46:35 PDT 2022


MatzeB added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:1501-1509
   // Conservatively, clear any kill flags, since it's possible that they are no
   // longer correct.
   // Note that we have to clear the kill flags for any register this instruction
   // uses as we may sink over another instruction which currently kills the
   // used registers.
   for (MachineOperand &MO : MI.operands()) {
     if (MO.isReg() && MO.isUse())
----------------
What about this code that already exists, is it not working for this example? If so, can it be fixed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126754/new/

https://reviews.llvm.org/D126754



More information about the llvm-commits mailing list