[PATCH] D126183: Implement soft reset of the diagnostics engine.
    Vassil Vassilev via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jun  6 06:32:08 PDT 2022
    
    
  
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
This looks good to me, modulo the inline comment.
Let's wait for @rsmith's green light.
================
Comment at: clang/lib/Interpreter/IncrementalParser.cpp:201
     // FIXME: Do not reset the pragma handlers.
-    Diags.Reset();
+    Diags.Reset(true);
     return llvm::make_error<llvm::StringError>("Parsing failed.",
----------------
```
    Diags.Reset(/*soft=*/true);
```
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126183/new/
https://reviews.llvm.org/D126183
    
    
More information about the llvm-commits
mailing list