[PATCH] D126889: [NFC] format InstructionSimplify & lowerCaseFunctionNames

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D126889#3559904 <https://reviews.llvm.org/D126889#3559904>, @foad wrote:

> No objection from me, and I do maintain downstream forks. Can you provide a simple one-line command that I can run to make the equivalent changes in my downstream?

I'm guessing this used a basic grep for "Simplify", but that needs refinement if we proceed - see inline comments for some mistakes.



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:394
 /// otherwise returns null.
 static Value *ThreadBinOpOverSelect(Instruction::BinaryOps Opcode, Value *LHS,
                                     Value *RHS, const SimplifyQuery &Q,
----------------
This should be updated.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4155
     // that this case returns nullptr as well.
-    auto PreventSelfSimplify = [V](Value *Simplified) {
+    auto PreventSelfsimplify = [V](Value *Simplified) {
       return Simplified != V ? Simplified : nullptr;
----------------
We don't want this change.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4596
           Q.DL.getPointerSizeInBits(AS)) {
-        auto CanSimplify = [GEPTy, &P, Ptr]() -> bool {
+        auto Cansimplify = [GEPTy, &P, Ptr]() -> bool {
           return P->getType() == GEPTy &&
----------------
We don't want this change.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5570
 
 static bool IsIdempotent(Intrinsic::ID ID) {
   switch (ID) {
----------------
This should be updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126889/new/

https://reviews.llvm.org/D126889