[PATCH] D109977: LLVM Driver Multicall tool

[Alex Brachet via Phabricator via llvm-commits]

abrachet marked 2 inline comments as done.
abrachet added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:2030
+    string(REPLACE "-" "_" key ${link_name})
+    string(REPLACE "+" "p" key ${key})
+    string(REPLACE "llvm-" "" tool_name ${link_name})
----------------
phosek wrote:
> Alternative substitution for `+` would be `x` which is used elsewhere in LLVM, for example `libcxx`, `libcxxabi` or `cxxfilt`.
Upon closer inspection we are no longer using that parameter of the macro, so I have removed it.


================
Comment at: llvm/tools/llvm-driver/llvm-driver.cpp:50
+  bool ConsumeFirstArg = false;
+  if (LaunchedTool == "llvm") {
+    if (Argc < 2)
----------------
MaskRay wrote:
> abrachet wrote:
> > MaskRay wrote:
> > > Some distributions may want to use something like llvm-15. See some binary utilities how the version is handled.
> > Thank's I've taken this from objcopy's code
> The format of `cl::PrintVersionMessage();` is not so good for user-facing tools. Consider omitting it.
> 
> `llvm-objcopy --version` should probably use a style similar to `clang --version` but the priority isn't high.
I've just removed `--version` completely for now. I don't think it is that pressing. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109977/new/

https://reviews.llvm.org/D109977