[PATCH] D126904: [llvm-objdump] Add support for dumping embedded offloading data

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Note: you probably need to consider jhenderson as a blocking reviewer for this change, even if folks who usually review offload changes give an approval.



================
Comment at: llvm/tools/llvm-objdump/ObjdumpOpts.td:86
+  HelpText<"Display the content of the offloading section">;
+def : Flag<["-"], "O">, Alias<offloading>,
+  HelpText<"Alias for --offload">;
----------------
Single-letter options can easily conflict with GNU objdump. Please drop it.
See https://github.com/llvm/llvm-project/issues/55297 that we spent many collaboration efforts with GNU.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126904/new/

https://reviews.llvm.org/D126904