[PATCH] D126159: [ADT] Add edit_distance_insensitive to StringRef

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 5 12:21:19 PDT 2022


dblaikie added inline comments.


================
Comment at: llvm/include/llvm/ADT/edit_distance.h:46
+template <typename T, typename Functor>
+unsigned ComputeMappedEditDistance(ArrayRef<T> FromArray, ArrayRef<T> ToArray,
+                                   Functor Map, bool AllowReplacements = true,
----------------
alexander-shaposhnikov wrote:
> as a side note, wouldn't it be a bit clearer / more flexible to pass a comparator instead ?
> 
oh, fair - I'd be open to that, but wouldn't insist


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126159/new/

https://reviews.llvm.org/D126159



More information about the llvm-commits mailing list