[PATCH] D124490: [InstrProf] Minimal Block Coverage

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/BlockCoverageInference.cpp:149
+        });
+    if (!HasSuperReachablePred)
+      for (auto *Pred : Preds)
----------------
I have other things to do and haven't read very carefully, but the impl here appears to differ from the algorithm description in the summary.

Having a SuperReachable Pred does not mean that `PredecessorDependencies[&BB]` should remain empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124490/new/

https://reviews.llvm.org/D124490