[PATCH] D127052: [amdgpu][nfc] Allocate kernel-specific LDS struct deterministically

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 4 09:43:48 PDT 2022


JonChesterfield added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp:123
+    // Avoid allocating dynamic lds padding between these variables
+    Align ModuleLDSTrailing = KV ? Align() : getDynLDSAlign();
+
----------------
this is both a negligible optimisation and decouples the layout from whether dynamic lds alignment is specified, which is useful for calculating where the variable is going to be from a context that doesn't know whether dynamic lds is in play


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127052/new/

https://reviews.llvm.org/D127052



More information about the llvm-commits mailing list